From 82ec3c167d0b71df60450f32c784e956e144fae0 Mon Sep 17 00:00:00 2001 From: Jacob Rothstein Date: Tue, 24 Oct 2023 10:46:57 -0700 Subject: [PATCH] http bugfix: address memory leak in after_send caused by std::mem::forget --- http/src/conn.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/http/src/conn.rs b/http/src/conn.rs index 8baa9f1ebe..c66e5ec33f 100644 --- a/http/src/conn.rs +++ b/http/src/conn.rs @@ -186,11 +186,7 @@ where } bufwriter.flush().await?; - - let mut after_send = std::mem::take(&mut self.after_send); - after_send.call(true.into()); - std::mem::forget(after_send); - + self.after_send.call(true.into()); self.finish().await }