feat(lltz_codegen): change of version + type and other fixes for smartpy compatibility #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tpy compatibilityi
alanmarkoTrilitech
requested review from
rinderknecht
and removed request for
rinderknecht
alanmarkoTrilitech
force-pushed
the
alan@lltz_codegen/smartpy_compatible
branch
from
1e14806
to
43ef79c
Compare
| (* Computes a map from free variables to their types in the given expression *) | ||
| let free_vars_with_types (expr : LLTZ.E.t) : LLTZ.T.t String.Map.t = | ||
| let empty = String.Map.empty in | ||
|
|
||
| let () = Printexc.record_backtrace true in |
There was a problem hiding this comment.
remove debug
| ) | ||
| with | ||
| | e -> | ||
| let backtrace = Printexc.get_backtrace () in |
There was a problem hiding this comment.
backtrace
|
|
||
| (* prim m n instr stack: m elements are consumed from the stack, n elements are produced *) | ||
| let prim m n instr stack = | ||
| M.pp Format.err_formatter instr; |
There was a problem hiding this comment.
remove pp
rinderknecht
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://app.asana.com/0/1207308081067689/1207308081144596
Description
This PR changes the OCaml version, adds support for annotations, fixes some type issues, adds optimisation for removing tuple variable via a single drop and also make multiple smaller adjustments/ bug fixes to make LLTZ compatible with Michel->LLTZ compilation.
Manual testing
./build test-scenario-mockup-lltz -j8 > temp.out from smartpy