Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release more frequently #59

Closed
Alex-D opened this issue Jun 3, 2019 · 7 comments
Closed

Release more frequently #59

Alex-D opened this issue Jun 3, 2019 · 7 comments
Labels
question Further information is requested

Comments

@Alex-D
Copy link

Alex-D commented Jun 3, 2019

There is no tagged release since 1.1.0 in January 2019 and master is ~90 commits ahead with lot of new things.

Consider tag and publish more frequently to help up keep our composer.json clean (no dev-master) and a easier way to check changes through time.

Thank you for your work :)

@froozeify
Copy link

For the next release I think they wait to merge #18 then #21

@Alex-D
Copy link
Author

Alex-D commented Jun 3, 2019

These PR are features, so we can easily image a 1.2.0 now and a 1.3.0 with the #21 ^^

@spideyfusion
Copy link
Contributor

We want to integrate #21 before tagging a new major release. There were a bunch of changes in-between which will require that we release it as 2.0.0.

We'll show more diligence in the future. :-)

Our next major focus is going to be full Symfony 4.3 support.

@Alex-D
Copy link
Author

Alex-D commented Jun 3, 2019

Is there breaking changes?
If not, 2.0.0 is not required
If yes, I am curious to know them since I'm on dev-master and it's hard to follow things via commit history.

Thank you and good luck! :)

@X-Coder264
Copy link
Collaborator

We are aware that there hasn't been a new release in a while and we will definitively try to be better in that regard in the future.

Just a bit of a background though - first there was a breaking change in SensioFrameworkExtraBundle regarding PSR-7 wiring in the DIC and then we also wanted to focus on making the bundle basically feature complete (aka merge in #18 and #21). #18 was merged today and we expect that #21 will be merged soon as well.

We'll have to tag the new release as 2.0 as there have been some breaking changes that happened on the master branch since 1.1.0 (like adding some methods to the interface in #53 for example). In general we expect the upgrade path to 2.0 to be easy and in the ideal case (which should be the case for most apps using the bundle IMO) without any required code changes in your apps.

@Nyholm
Copy link
Contributor

Nyholm commented Jun 17, 2019

May I suggest to release a 2.0.0-alpha1 for us early adopters? We can release that now so people can test and find bugs.

@spideyfusion
Copy link
Contributor

Done deal!

https://github.com/trikoder/oauth2-bundle/releases/tag/v2.0.0-beta1

@Alex-D Alex-D closed this as completed Jun 19, 2019
@spideyfusion spideyfusion added the question Further information is requested label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants