Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorizationResolution not approving authenticated users #32

Closed
sidiboshut opened this issue Mar 11, 2019 · 8 comments
Closed

authorizationResolution not approving authenticated users #32

sidiboshut opened this issue Mar 11, 2019 · 8 comments
Labels
invalid This doesn't seem right

Comments

@sidiboshut
Copy link

sidiboshut commented Mar 11, 2019

I am using a fork from this repo [ajgarlag]https://github.com/ajgarlag/oauth2-bundle/tree/feature/authorization_code).
I managed to set it up, but there is a bug regarding AuthorizationRequestResolveEvent which is not approving authenticated user, so there is unauthorised error being thrown after a user has successfully logged.

@alenpokos
Copy link

@sidiboshut We are working with ajgarlag to incorporate these changes into main repo. As this is still work in progress it might not be safe to use it for other than development and testing.
Do you have any additional pointers to how you got the bug / how to reproducte it or where it might be caused from?

@ajgarlag
Copy link
Contributor

@sidiboshut It would be useful to see the code of the listener that listen to the AuthorizationRequestResolveEvent to approve the authorization request.

@sidiboshut
Copy link
Author

sidiboshut commented Mar 12, 2019

@alenpokos I am using this in dev mode for now and using a fork from @ajgarlag fork.
To reproduce it, just do the normal setup and protect /authrize endpoint so only logged in users can access it.
You also need to set an authentication login form guard in your security.yml file.
This is where it's occurring and how I fixed it as a work around for now in my fork.
Please let me know if you need more details.

@ajgarlag
Copy link
Contributor

Instead of this change to the event class, you should add an event listener to approve the authorization request.

See https://github.com/ajgarlag/oauth2-bundle/blob/feature%2Fauthorization_code/Tests/Acceptance/AuthorizationEndpointTest.php#L18

@sidiboshut
Copy link
Author

Yes I was just looking at that bit, it sounds a better fix.
I will do that instead.
Thx

@sidiboshut
Copy link
Author

I have added a Listener for it in here.

@X-Coder264
Copy link
Collaborator

@sidiboshut We have merged #18 into the bundle. Does everything work for you with our dev-master version?

@X-Coder264
Copy link
Collaborator

Closing due to inactivity. If you still have problems with this even with our dev-master version feel free to ping me and I'll reopen it again.

@spideyfusion spideyfusion added the invalid This doesn't seem right label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

5 participants