Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri stacked borrows improvements for inflate #237

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

folkertdev
Copy link
Collaborator

working towards fixing #233

this now works with stacked borrows (the default)

cargo +nightly miri nextest run -p test-libz-rs-sys inflate::

cc @inahga

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
zlib-rs/src/inflate.rs 94.44% 1 Missing ⚠️
zlib-rs/src/inflate/window.rs 97.14% 1 Missing ⚠️
zlib-rs/src/weak_slice.rs 97.05% 1 Missing ⚠️
Files with missing lines Coverage Δ
zlib-rs/src/allocate.rs 98.98% <100.00%> (+0.02%) ⬆️
zlib-rs/src/inflate/bitreader.rs 90.62% <100.00%> (ø)
zlib-rs/src/inflate/writer.rs 87.66% <100.00%> (ø)
zlib-rs/src/lib.rs 92.98% <ø> (ø)
zlib-rs/src/inflate.rs 95.07% <94.44%> (+<0.01%) ⬆️
zlib-rs/src/inflate/window.rs 97.57% <97.14%> (+0.09%) ⬆️
zlib-rs/src/weak_slice.rs 97.05% <97.05%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@inahga inahga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@folkertdev folkertdev merged commit 71cd8a8 into main Oct 25, 2024
18 checks passed
@folkertdev folkertdev deleted the miri-stacked-borrows-improvements branch October 25, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants