Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline copy_match_help #180

Merged
merged 2 commits into from
Sep 12, 2024
Merged

inline copy_match_help #180

merged 2 commits into from
Sep 12, 2024

Conversation

folkertdev
Copy link
Collaborator

this is very effective

Benchmark 2 (153 runs): ./target/release/examples/blogpost-uncompress rs silesia-small.tar.gz
  measurement          mean ± σ            min … max           outliers         delta
  wall_time          32.7ms ±  332us    32.0ms … 34.9ms          2 ( 1%)        ⚡-  6.1% ±  0.2%
  peak_rss           24.1MB ± 64.6KB    23.9MB … 24.1MB          0 ( 0%)          -  0.6% ±  0.1%
  cpu_cycles         94.6M  ±  788K     94.1M  …  102M           8 ( 5%)        ⚡-  9.1% ±  0.2%
  instructions        305M  ±  282       305M  …  305M           0 ( 0%)        ⚡- 12.8% ±  0.0%
  cache_references   2.13M  ± 82.5K     2.08M  … 3.01M           6 ( 4%)          -  1.6% ±  0.7%
  cache_misses       32.7K  ± 2.73K     28.9K  … 47.3K           8 ( 5%)        ⚡- 26.7% ±  1.7%
  branch_misses       951K  ±  751       950K  …  956K           2 ( 1%)          -  0.5% ±  0.0%

this is very effective

Benchmark 2 (153 runs): ./target/release/examples/blogpost-uncompress rs silesia-small.tar.gz
  measurement          mean ± σ            min … max           outliers         delta
  wall_time          32.7ms ±  332us    32.0ms … 34.9ms          2 ( 1%)        ⚡-  6.1% ±  0.2%
  peak_rss           24.1MB ± 64.6KB    23.9MB … 24.1MB          0 ( 0%)          -  0.6% ±  0.1%
  cpu_cycles         94.6M  ±  788K     94.1M  …  102M           8 ( 5%)        ⚡-  9.1% ±  0.2%
  instructions        305M  ±  282       305M  …  305M           0 ( 0%)        ⚡- 12.8% ±  0.0%
  cache_references   2.13M  ± 82.5K     2.08M  … 3.01M           6 ( 4%)          -  1.6% ±  0.7%
  cache_misses       32.7K  ± 2.73K     28.9K  … 47.3K           8 ( 5%)        ⚡- 26.7% ±  1.7%
  branch_misses       951K  ±  751       950K  …  956K           2 ( 1%)          -  0.5% ±  0.0%
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (660f699) to head (ae07cd9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   92.63%   92.65%   +0.02%     
==========================================
  Files          44       44              
  Lines       14827    14938     +111     
==========================================
+ Hits        13735    13841     +106     
- Misses       1092     1097       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@folkertdev folkertdev merged commit 23b38f8 into main Sep 12, 2024
18 checks passed
@folkertdev folkertdev deleted the inline-copy-match-help branch September 12, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant