Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design signed data blob for translations #988

Closed
4 tasks done
tsusanka opened this issue May 13, 2020 · 2 comments
Closed
4 tasks done

Design signed data blob for translations #988

tsusanka opened this issue May 13, 2020 · 2 comments
Assignees
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone

Comments

@tsusanka
Copy link
Contributor

tsusanka commented May 13, 2020

During discussions on #987 @prusnak came up with an idea to use one whole memory block in Trezor's storage for signed blob of data received from the Host. The blob will contain mainly the translation strings for the chosen language, however its usage might be broader (e.g. coininfo etc.). We currently assume it would have 128KB.

This blob can be replaced only as a whole. We might split the blob into parts, provide hashes for each part and update only the parts that has changed. However, since uploading 128KB should take about 1s (fair guesstimate) this should be quite seamless for the user. We will consider this optimization later then, if necessary.

This issue covers:

  • Design and document how the blob data will be structured.
  • Provide API to access the data.
  • Research whether this is applicable for T1 as well.
  • Research what the is the appropriate blob size. Is 128K the correct size?

Part of #987. Related: signing the blob #1016, exchange mechanism #1017

@tsusanka tsusanka added core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature labels May 13, 2020
@tsusanka tsusanka added this to the backlog milestone May 13, 2020
@prusnak
Copy link
Member

prusnak commented May 13, 2020

I came up with the following blob structure: https://github.com/trezor/trezor-firmware/blob/master/docs/storage/addon-block.md

Let's discuss this further whether this meets our needs.

@tsusanka tsusanka modified the milestones: backlog, 2020-07 May 21, 2020
@tsusanka tsusanka changed the title Store signed data blob in storage Design signed data blob in storage May 26, 2020
@tsusanka tsusanka changed the title Design signed data blob in storage Design signed data blob for translations May 26, 2020
@prusnak
Copy link
Member

prusnak commented May 29, 2020

Push the design of the i18n-block + modtrezori18n prototype to thei18n-block branch.

I think the size 128K is fine and this is applicable for T1 as well.

Lowering priority as all of the core tasks are done.

We can continue the work on this once #991 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Development

No branches or pull requests

2 participants