Read action's secrets from env vars and avoid logging them #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
force-pushed
the
2282-secrets-actions
branch
from
d876383
to
05405ba
Compare
johnnyaug
reviewed
Aug 9, 2021
.github/workflows/nessie.yaml
Outdated
| @@ -375,6 +375,7 @@ jobs: | |||
| TAG: ${{ needs.deploy-image.outputs.tag }} | |||
| # Setting Account_ID as a secret as a way to avoid specifying it here | |||
| REPO: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.us-east-1.amazonaws.com | |||
| ACTIONS_VAR: "this_is_actions_var" | |||
There was a problem hiding this comment.
If possible, inject this env var from the test code and not from here - otherwise when running locally, one has to make sure the var is set in order for the test to work.
There was a problem hiding this comment.
lakeFS is running separately from the test code. I can't control it from the test code, I can set it always in lakeFS but that seems like too much. WDYT?
johnnyaug
suggested changes
Aug 9, 2021
itaiad200
force-pushed
the
2282-secrets-actions
branch
from
2ac9322
to
8da8147
Compare
itaiad200
force-pushed
the
2282-secrets-actions
branch
from
6a66d0b
to
db9d234
Compare
johnnyaug
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2282
This implementation assumes that secrets are to be used only in specific locations and are not available in all places. For example, query-params & headers are good place for secrets, but the url itself isn't.
While this might limit the users a bit when trying to pass variables to the execution itself, it will allow us to log all other parameters of the actions, without worrying about leakage of secrets. Env var references in other places in the action yaml file are simply ignored.