Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test suite #1

Closed
treeowl opened this issue Aug 12, 2020 · 11 comments
Closed

Add a test suite #1

treeowl opened this issue Aug 12, 2020 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed urgent Release blockers and such

Comments

@treeowl
Copy link
Owner

treeowl commented Aug 12, 2020

No description provided.

@treeowl treeowl added enhancement New feature or request urgent Release blockers and such labels Aug 12, 2020
@treeowl
Copy link
Owner Author

treeowl commented Aug 12, 2020

@sjakobi, do you think you could help set up the skeleton of this? I can write all the generators and properties I need, but getting Travis and the testing framework set up is not exactly my forte.

@treeowl treeowl added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 12, 2020
@lemmih
Copy link
Contributor

lemmih commented Aug 13, 2020

Are you open to using github actions instead of travis ci?

@treeowl
Copy link
Owner Author

treeowl commented Aug 13, 2020

Are you open to using github actions instead of travis ci?

I don't know anything about GitHub actions. What are the advantages and disadvantages? Last I checked, most Haskell packages were using Travis.

@lemmih
Copy link
Contributor

lemmih commented Aug 13, 2020

Advantages: built-in with github and easy to use. Disadvantages: quite new and probably not worth the move if you already have a working Travis script.

I'll submit a PR for a github action that tests several versions of GHC across linux, mac and windows.

@treeowl
Copy link
Owner Author

treeowl commented Aug 13, 2020

Having Someone Else willing to do the setup work is a huge boost for That Person's choice. Thanks!

@sjakobi
Copy link

sjakobi commented Aug 13, 2020

@sjakobi, do you think you could help set up the skeleton of this?

I'll wait for @lemmih's CI PR first.

@treeowl
Copy link
Owner Author

treeowl commented Aug 13, 2020

@sjakobi thanks! It looks like that's almost done.

@sjakobi
Copy link

sjakobi commented Aug 13, 2020

Which testing framework do you want to use, @treeowl?

containers and u-c use test-framework, but that's hardly maintained these days. Fairly close in spirit is tasty, and its maintainer offers pretty great support too.

I'm less familiar with hspec, but that has a lot of proponents too. See e.g. the discussion in haskell-unordered-containers/unordered-containers#284.

@treeowl
Copy link
Owner Author

treeowl commented Aug 13, 2020

@sjakobi, I don't care very much. I just want to write my generators and tests and have them run, and make sure CI makes noisy noises when they fail.

@sjakobi
Copy link

sjakobi commented Aug 14, 2020

@lemmih was faster again. Thanks, @lemmih! :)

@treeowl
Copy link
Owner Author

treeowl commented Aug 15, 2020

Done!

@treeowl treeowl closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed urgent Release blockers and such
Projects
None yet
Development

No branches or pull requests

3 participants