Variables that will be expanded in double quoted strings are not parsed as variables

[Ben3eeE]

http://php.net/manual/en/language.types.string.php#language.types.string.parsing

Program:

<?php
$juice = "apple";

echo "He drank some $juice juice.".PHP_EOL;
// Invalid. "s" is a valid character for a variable name, but the variable is $juice.
echo "He drank some juice made of $juices.";
// Valid. Explicitly specify the end of the variable name by enclosing it in braces:
echo "He drank some juice made of ${juice}s.";
?>

Output:

He drank some apple juice.
He drank some juice made of .
He drank some juice made of apples.

Parser:
All of these variables are parsed as string:

text.html.php
program
echo_statement
string

Version:
0.13.0

[patrickt]

Interpolated strings in general are pretty tricky. Looks like we might be able to get away with an interpolated_string rule that contains the matched variable names.

[Ben3eeE]

There is also the Complex (curly) syntax. If you surround the variable with curly brackets you can do more complex interpolated strings that you otherwise can't like:

// Works, quoted keys only work using the curly brace syntax
echo "This works: {$arr['key']}";

Maybe this will complicate things 😅

[patrickt]

Oof, that’s tricky as well.

[maxbrunsfeld]

Seems like strings work somewhat similarly to double quoted strings in bash? Here's our current rule for that in the bash parser: https://github.com/tree-sitter/tree-sitter-bash/blob/5203b504db454180de58af6f0ea6fc10df47b487/grammar.js#L417-L430.