Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[digdag-ui]Workflow Page bloats memory usage of browser #1652

Closed
snagasawa opened this issue Oct 3, 2021 · 2 comments · Fixed by #1741
Closed

[digdag-ui]Workflow Page bloats memory usage of browser #1652

snagasawa opened this issue Oct 3, 2021 · 2 comments · Fixed by #1741

Comments

@snagasawa
Copy link
Contributor

snagasawa commented Oct 3, 2021

WorkflowVIew uses ReactInterval to fetch the project's archive file every few seconds in order to display the workflow definition and task files.

<WorkflowFilesView workflow={wf} projectArchive={this.state.projectArchive} />

<ReactInterval timeout={refreshIntervalMillis} enabled={Boolean(true)} callback={() => this.fetch()} />

fetchProjectArchiveWithRevision (projectId: string, revisionName: string): Promise<ProjectArchive> {

But, fetching the project's archive file bloats memory usage of the browser. Some of archive files of my Digdag projects over 10MB.

This is a capture of the Task Manager in Google Chrome.
As long as the Workflow Page is open, the number of Dedicated Workers will continue to grow like this.
image

And here is the list of requests in the network tab of devtools.
image

It seems too heavy to fetch the archive file every few seconds.

Any feedback would be much appreciated.
Thanks.

@snagasawa snagasawa changed the title Workflow View bloats memory usage of browser [digdag-ui]Workflow Page bloats memory usage of browser Oct 3, 2021
@seiyab
Copy link
Contributor

seiyab commented Dec 7, 2021

I wonder that garbage collection doesn't work.

@snagasawa
Copy link
Contributor Author

@seiyab
Thanks for replying.
I created PR fix this issue. #1741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants