-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xattrs do not work on nfs mounted mergerfs pool #1132
Comments
Hm... not sure why it wouldn't work if you have xattrs enabled in mergerfs. Maybe there is something funny with how FUSE and NFS work together in this regard. I'll setup a NFS share and check it out. |
Yeah I forgot to mention that xattrs work locally in the mergerfs pool with these configs, they only don't work when accessing the pool through nfs. |
My guess is that it is a kernel thing. I'll ask the FUSE authors. |
I'm almost positive I tested this and had the issues you mention but I just tested again and it is working fine. Kernel 5.15 on Ubuntu and Mint systems. Can you double check the setup and instructions to reproduce? |
@trapexit I've tested it again on Arch with kernel 6.1.12 and got the same results. This time I set up a MergerFS pool on the system drive and NFS server and client on the same machine as I don't have the original setup. Seeing how that's enough to reproduce the bug, I've made a script to make it easier to test: #!/bin/bash
set -euo pipefail
# Set test root folder
TEST_ROOT="/mnt/mergerfs-xattrs-test"
# Create required directories
mkdir -p $TEST_ROOT/{disks/{1,2,3},pool,client}
# Mount MergerFS pool
mergerfs -o defaults,nfsopenhack=all,xattr=passthrough "$TEST_ROOT/disks/*" "$TEST_ROOT/pool"
# Setup NFS exports
NFS_EXPORT_LINE="$TEST_ROOT/pool 127.0.0.1(rw,fsid=0,no_root_squash,no_subtree_check)"
NFS_EXPORT_FILE="/etc/exports"
grep -qF -- "$NFS_EXPORT_LINE" "$NFS_EXPORT_FILE" || echo "$NFS_EXPORT_LINE" >>"$NFS_EXPORT_FILE"
# Start NFS server and refresh exports
systemctl start nfsv4-server.service
exportfs -ar
# Setup NFS client
mount -t nfs -o vers=4 127.0.0.1:/ "$TEST_ROOT/client"
# Perform test
touch "$TEST_ROOT/client/test"
if attr -s foo -V bar "$TEST_ROOT/client/test"; then
RESULT="PASS"
else
RESULT="FAIL"
fi
# Cleanup
awk -i inplace -v line="$NFS_EXPORT_LINE" '!index($0,line)' "$NFS_EXPORT_FILE"
exportfs -ar
sleep 1s # wait for mounts to not be busy
umount "$TEST_ROOT/client"
umount "$TEST_ROOT/pool"
rm -rf "$TEST_ROOT"
# Print result
echo "MergerFS xattrs test: $RESULT" Here's the output I get on my system (running the script with
|
Thanks. Will take a look and get back to the kernel folks. |
Have you tried setting fsid and not using the mounting of root path like that? Because besides that I simply can't reproduce this on 5.15 on Ubuntu. It works fine if I change the fsid and mount the full path. I don't know why that would matter but it appears to and for me if you just make those changes to your script it works as desired. |
You're right, after doing the following changes it works as expected: # Setup NFS exports
-NFS_EXPORT_LINE="$TEST_ROOT/pool 127.0.0.1(rw,fsid=0,no_root_squash,no_subtree_check)"
+NFS_EXPORT_LINE="$TEST_ROOT/pool 127.0.0.1(rw,fsid=1,no_root_squash,no_subtree_check)" # Setup NFS client
-mount -t nfs -o vers=4 127.0.0.1:/ "$TEST_ROOT/client"
+mount -t nfs -o vers=4 "127.0.0.1:$TEST_ROOT/pool" "$TEST_ROOT/client It is very odd and I'd still consider it a bug, as I see no reason why it shouldn't work in the first scenario. But I guess the issue is probably with NFS and at least there's this workaround now. Though it still might have something to do with how MergerFS interacts with NFS, as running the first case (with |
Not sure but at most it is a FUSE <-> NFS issue as mergerfs is not behaving any differently between these two situations. I'll do some more investigation and talk to the kernel devs. |
Describe the bug
nfs supports xattrs since Linux 5.9 and nfs 4.2. I have tested it on my setup by exporting a regular folder on an ext4 filesystem over nfs and attempting to use xattrs. However, when exporting a mergerfs pool over nfs, trying to use xattrs errors with
Operation not supported
. I have tried using thenfsopenhack=all
option, but it does not help. From thenfsopenhack
description it's unrelated anyway, so I did not expect it to help, but it was the only relevant option I could try.To Reproduce
/mnt/storage/pool
/etc/exports
:Expected behavior
The xattr gets set successfully on the client host:
And can be accessed afterwards on the client host:
System information:
NixOS unstable, Linux 6.1.8
2.34.1
df -h
:lsblk -f
:The text was updated successfully, but these errors were encountered: