-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspiration: Fine Uploader, Dropzone #59
Comments
Thanks for the suggestion! I think we had an internal discussion on this and decided to adopt https://github.com/feross/drag-drop for our own DragDrop plugin, so it can deal with some browser edge cases, while staying relatively small dependency wise. We are considering writing a Dropzone plugin, just for demo purposes. We'll be discussing these with the team as well, they probably need to be added to other Plugins that we have:
Would you be interested to stay involved so we don't screw things up for your use-case? 😄 |
would be a pleasure :-) just send a hint where the demo with latest version could always be found and I'll do my best to document possible issue...
This would be awesome and would help in at least 4 points
|
thanks for pointing to https://github.com/feross/drag-drop |
I like the way you're thinking! Thanks for the ideas! As for the most recent demo, this our biggest one: http://uppy.io/examples/modal/index.html |
It has been mentioned on Hacker News that Fine Uploader http://fineuploader.com/ is also a worthy library to look at, and from the first look it seems so, I hope we can implement the best from it too. |
Fine Uploader is MIT too. If uppy can benefit from any of the hard work I've put into Fine Uploader over the years, let me know. Perhaps some work can be done to carve out some of the more complicated FU features, such as concurrent chunking, image scaling, folder uploads, upload to S3, or upload to Azure, and turn them into standalone npm modules for other libraries to use. I would certainly be willing to talk more about this or anything else with the transloadit folks. |
Hi @rnicholus! While we were working on tus, we (Transloadit) have always been recommending our customers to use Fine Uploader if they required resumability, and letting us import from their bucket to do the processing. Hence, it's great to see you reach out, thanks! As you maybe have seen, we have finalized tus. We see tus as a great way to deploy resumability in a non-vendor-locked-in way. However, direct S3 upload (or Azure for that matter), remains a great solution for people to whom that is an acceptable trade-off, towards not having to run and scale their own infra. So we see a great future for both, and our goal with Uppy is to offer as many sensible plugins as possible, and let the user, or a preset, decide what makes for the use-case at hand. In this light, we are very interested in adopting FineUploader's years of experience, especially when it comes to directly uploading to these vendors. The suggested approach of carving out your work into separate re-usable modules seems very appealing. Is there any way we can assist you in this? |
I do vaguely recall talking to some someone or some people at Transloadit years ago re Fine Uploader integration, but I can't recall the specifics. May have been a Twitter discussion. Anyway, I'm certainly all for further modularizing Fine Uploader. As already mentioned, this allows useful pieces to be pulled into other libraries, but it also provides additional focus and isolation when sorting out and fixing bugs and features. That said, I think the first step is to identify the most useful components of Fine Uploader as candidates for refactoring into standalone npm modules. The library already has a number of its features and endpoint handlers divided up into specific source files, but there are still inter-dependencies that may need to be removed or addressed in some way to make some of these truly standalone. Even the DnD "module", which handles file and folder dropping, depends on other internal modules to some degree. Most of my available FOSS time is currently spent answering questions from users/integrators on Stack Overflow, along with feature requests and bug reports in the project's issue tracker. After that, I've been focusing more lately on react-fine-uploader, which is a project that aims to wrap Fine Uploader core and duplicate Fine Uploader UI as a series of very focused React components, along with a wrapper for Fine Uploader core that provides additional conveniences, such as the ability to register multiple handlers for a specific event/callback (something that is needed by the React components). But I'd still be open to further discussions, direction, and coding to help with the efforts associated with modularizing Fine Uploader, as time allows. Also, feel free to ask any questions that may come up during your development of uppy. Perhaps my experience in this area can be of some help as well. |
Re. FineUploader/fine-uploader#1881 it would be great if you talked again! I would love to see some more of Fine Uploader's features as plugins. Especially chunked uploading would be great. |
Thanks for reaching out! How exactly do you mean chunked uploading? Don't our Tus and S3 plugins already support that? Are you looking for something special here? (I'm likely overlooking something) |
Perhaps you're talking about:
? This is something the tus protocol supports via the Concat extension, but we haven't enabled just yet. With browsers limiting how many connections they're willing to open to the same domain, we'd have to wonder (no, test) really how much faster uploads will become in that environment tho. For good measure, I think it's interesting to maybe list Fine Uploaders features and see if we have parity or no (this is not an exhaustive list of Uppy features, just comparing against FU):
^-- Not sure about a few of these. Also not sure if we'll want to support all of these |
@kvz Quick question on the list above - does Uppy not upload chunks in parallel via Tus today or is this item referring to some more nuanced feature?
|
The nuance is in parallel uploading of said chunks, we don’t do that, and unsure if we will in the near future due to said browser constraints and limited expected performance improvements. We should test this tho, if I’m wrong, it’s gonna be relatively easy to just leverage the tus Concat Extension
Sent from mobile, pardon the brevity.
… On 30 Sep 2017, at 22:38, Anuj ***@***.***> wrote:
@kvz Quick question on the list above - does Uppy not upload chunks in parallel via Tus today or is this item referring to some more nuanced feature?
File Chunking / Partitioning (parallel uploading) -- Splitting a file into smaller pieces allows for a more efficient overall upload, and powers some Fine Uploader features such as pausing, and resuming uploads. Fine Uploader can also upload multiple chunks for the same file concurrently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I'll close this since I don't think this issue is actionable right now—we have separate open PRs or issues for several of the features in @kvz's list overview and if someone needs another feature they can open a specific issue for it too. Thanks! |
Maybe one could adopt / learn some interesting things
from https://github.com/enyo/dropzone
e.g.regarding
http://www.dropzonejs.com/#configuration-options
may help to reinvent the wheel in all details again...
Would be perfectly match to other awesome planned features of uppy!!!
The text was updated successfully, but these errors were encountered: