Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Uppy/locals is missing other language environments in the dist directory, and by default, only en-US.min.js is available #5051

Closed
2 tasks done
ajiho opened this issue Mar 29, 2024 · 1 comment · Fixed by #5055
Labels

Comments

@ajiho
Copy link

ajiho commented Mar 29, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

https://www.npmjs.com/package/@uppy/locales?activeTab=code

Expected behavior

https://github.com/transloadit/uppy/tree/main/packages/%40uppy/locales/src All translation files in this directory should produce. min files

Actual behavior

Otherwise, I would add type="module" to my script, for example, because I am directly using CDN mode for development

<script type="module" src="lib/@uppy/locales/lib/zh_CN.js"></script>
<script type="module">
  $(document).ready(function () {
    const uppy = new Uppy.Uppy({
      debug: true,
      locale: Uppy.locales.zh_CN,
    });
})
</script>

I hope to get

<script src="lib/@uppy/locales/dist/zh_CN.min.js"></script>
<script>
  $(document).ready(function () {
    const uppy = new Uppy.Uppy({
      debug: true,
      locale: Uppy.locales.zh_CN,
    });
})
</script>
@ajiho ajiho added the Bug label Mar 29, 2024
@Murderlon
Copy link
Member

Hi, think this was a mistake and we shouldn't do dist altogether. We never minify code in our plugins before publishing and this is the only exception. All the locales are present in lib already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants