Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using the JobScheduler at Android 21 #2

Merged
merged 1 commit into from
May 30, 2019

Conversation

raphaelmerx
Copy link
Contributor

All the android.app.job functionality was added in Android Lollipop (api level 21), but this plugin starts taking advantage of it in api level 22. Here I'm changing the conditionals from Build.VERSION_CODES.LOLLIPOP_MR1 to Build.VERSION_CODES.LOLLIPOP

@christocracy
Copy link
Member

christocracy commented Mar 6, 2018

I believe I copied this block from my background-geolocation plugin where I chose api 22 in order to JobRequest#setExtras. I don’t think extras is required for fetch so should be fine.

Thanks for walking into the code.

@raphaelmerx
Copy link
Contributor Author

@christocracy any blocker with merging this?

@christocracy
Copy link
Member

No. Just haven't had a chance to test it.

@christocracy christocracy merged commit d5d8c23 into transistorsoft:master May 30, 2019
christocracy added a commit to transistorsoft/react-native-background-fetch that referenced this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants