-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This mainly was left in by misskey to keep consistency so it's not just like woop all of a sudden the status indicator is not here while on other profiles it is.
A big issue I see with this is performance on the client as the more CSS Effects need to be rendered (especially on the profile page as it also has css effects for the background images which currently affect the entire site on stable and has already been fixed) the slower/laggier it gets. |
While this is a nice idea on paper it kinda translates weirdly due to the fact that it makes it harder to indicate if someone is hovering over the footer icons, cw button and as well as making the cursor be basically a permanent pointer (which lets be honest when it comes to the way the pointer looks it has always looked weird/ugly). |
👍, dropping that commit in this case
true, but imo there needs to be some way to separate things from the background, barely perceptible color changes do not cut it (especially on pages without a background image) there may be a way to pull it off with borders which should be slightly more resource efficient, i'll have to experiment
right now there is no other indication on what part of a note is clickable and what part isn't. especially on posts with reactions or audio where the empty space next to them do not open the post (or the empty space under the avatar, which in fairness seems to be consistent with masto) the footer icons can be solved by giving them a hover color (which i'll may throw in with the next revision of this pr, depends on if my brain's willing to cooperate) (edit: there already seems to be css for doing this. are the colors just the same in the default themes?) and the cw button changes background colors which feels reasonable to me (and the cursor doesn't change because the post hitbox is that close to the cw button) not entirely sure on what you mean by "and as well as making the cursor be basically a permanent pointer (which lets be honest when it comes to the way the pointer looks it has always looked weird/ugly)." though |
107ece1
to
98dc045
Compare
there are a few more changes i'd like to make but they're significantly larger and probably deserve their own individual PRs (if i manage to pull them off, that is). un-drafting this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said on Discord the borders don't look good depending on the theme you use and it would probably be good to avoid trying to separate the background and containers for now until a better solution can be found.
dropped borders & rebased on develop |
before
after
there are three parts of this pr i'm not too sure on: