Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worflow run behaviour #8

Open
monsieurleberre opened this issue Jun 1, 2022 · 0 comments
Open

Fix worflow run behaviour #8

monsieurleberre opened this issue Jun 1, 2022 · 0 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@monsieurleberre
Copy link
Contributor

Currently worflow_run doesn't happen in the context of the caller workflow, which means that the branch is always the default one, and the tagging will get wrong on release branches.
Instead of using github.ref_name and getting the dev branch for instance
one should use github.event.workflow_run to get the calling workflow branch

we should probably try to get rid of the anothrNick/[email protected] action all together to be honest
@monsieurleberre monsieurleberre added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@monsieurleberre