Fix incorrect ternary conversion on Return node (close #115)

crytic · Dec 23, 2018 · c8952db · c8952db
1 parent b31fdc4
commit c8952db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/slither/core/cfg/node.py b/slither/core/cfg/node.py
@@ -138,6 +138,10 @@ def type(self):
         """
         return self._node_type
 
+    @type.setter
+    def type(self, t):
+        self._node_type = t
+
     @property
     def variables_read(self):
         """

diff --git a/slither/solc_parsing/declarations/function.py b/slither/solc_parsing/declarations/function.py
@@ -857,12 +857,16 @@ def split_ternary_node(self, node, condition, true_expr, false_expr):
         if node.type == NodeType.VARIABLE:
             assert isinstance(true_expr, AssignmentOperation)
             #true_expr = true_expr.expression_right
+        elif node.type == NodeType.RETURN:
+            true_node.type = NodeType.RETURN
         true_node.add_expression(true_expr)
         true_node.analyze_expressions(self)
 
         false_node = self._new_node(NodeType.EXPRESSION, node.source_mapping)
         if node.type == NodeType.VARIABLE:
             assert isinstance(false_expr, AssignmentOperation)
+        elif node.type == NodeType.RETURN:
+            false_node.type = NodeType.RETURN
             #false_expr = false_expr.expression_right
         false_node.add_expression(false_expr)
         false_node.analyze_expressions(self)