Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin docs #2554

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix plugin docs #2554

merged 2 commits into from
Jun 1, 2022

Conversation

lordidiot
Copy link
Contributor

Noticed some callbacks in the plugin docs were not accurate.
Updated them based on how they were being _published in the codebase, hopefully it is accurate.

  1. did_fork_state_callback
    • Based on 1 and 2
  2. did_evm_read_callback / did_evm_write_callback
    • Based on 1 and 2

ekilmer
ekilmer approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ekilmer ekilmer merged commit dc99880 into trailofbits:master Jun 1, 2022
ekilmer added a commit that referenced this pull request Jun 1, 2022
@ekilmer
Merge branch 'master' into chess
e761932 
* master:
  Fix plugin docs (#2554)
  Use protobuf version 3 (#2558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekilmer ekilmer ekilmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lordidiot @ekilmer