Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Available workers decrease over time? #2427

Open
ggrieco-tob opened this issue Apr 7, 2021 · 0 comments · May be fixed by #2450
Open

Available workers decrease over time? #2427

ggrieco-tob opened this issue Apr 7, 2021 · 0 comments · May be fixed by #2450
Labels
bug

Comments

@ggrieco-tob
Copy link
Contributor

It seems that once a state goes from busy to killed, the worker handling that state will not take another one. This cases are not so rare to happen, for instance:

manticore/manticore/platforms/evm.py

Lines 1244 to 1257 in 3da969b

elif issymbolic(should_check_jumpdest):
self._publish("will_solve", self.constraints, should_check_jumpdest, "get_all_values")
should_check_jumpdest_solutions = SelectedSolver.instance().get_all_values(
self.constraints, should_check_jumpdest
)
self._publish(
"did_solve",
self.constraints,
should_check_jumpdest,
"get_all_values",
should_check_jumpdest_solutions,
)
if len(should_check_jumpdest_solutions) != 1:
raise EthereumError("Conditional not concretized at JMPDEST check")

This impacts the use of manticore on larger targets that require to run for a while, since it is likely that some workers will stop degrading the overall performance of our tool. Also, in the extreme case, where manticore is configured with one worker, it will hang forever (until the user press ctrl+c or the process gets killed)
@ggrieco-tob ggrieco-tob added the bug label Apr 7, 2021
@ggrieco-tob ggrieco-tob linked a pull request May 9, 2021 that will close this issue
Open
@ehennenfent ehennenfent linked a pull request May 11, 2021 that will close this issue
Start new workers as more states are killed #2450
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Start new workers as more states are killed trailofbits/manticore
1 participant
@ggrieco-tob