Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an allow-list to the list of packages from which imports are considered safe #14

Open
adrinjalali opened this issue Feb 18, 2022 · 1 comment

Comments

@adrinjalali
Copy link

adrinjalali commented Feb 18, 2022

Right now the scanner checks if there is any imports from a package which is not a part of the standard library. However, when it comes to dumps of machine learning models, they are going to have imports from the used libraries (e.g. scikit-learn, numpy, scipy, lightgbm, etc).

It would be nice to have an option to include a list of libraries which are considered safe by the user, and not raise a warning on their imports.

We are planning to use this library at @huggingface, but such a modification is necessary to make it work for us. It would be really nice if we could include it in the upstream.

cc @McPatate (who would be happy to work on a PR).

WDYT @ESultanik ?

@McPatate
Copy link

@adrinjalali you got my handle wrong 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants