Fix ACME renew & add version check

README.md

@@ -52,7 +52,7 @@ Run it and forget it!
 - Circuit breakers on backends
 - Round Robin, rebalancer load-balancers
 - Rest Metrics
-- [Tiny](https://imagelayers.io/?images=traefik) [official](https://hub.docker.com/r/_/traefik/) docker image included
+- [Tiny](https://microbadger.com/images/traefik) [official](https://hub.docker.com/r/_/traefik/) docker image included
 - SSL backends support
 - SSL frontend support (with SNI)
 - Clean AngularJS Web UI

acme/acme.go

@@ -136,12 +136,14 @@ func (a *ACME) CreateClusterConfig(leadership *cluster.Leadership, tlsConfig *tl
 	leadership.Pool.AddGoCtx(func(ctx context.Context) {
 		log.Infof("Starting ACME renew job...")
 		defer log.Infof("Stopped ACME renew job...")
-		select {
-		case <-ctx.Done():
-			return
-		case <-ticker.C:
-			if err := a.renewCertificates(); err != nil {
-				log.Errorf("Error renewing ACME certificate: %s", err.Error())
+		for {
+			select {
+			case <-ctx.Done():
+				return
+			case <-ticker.C:
+				if err := a.renewCertificates(); err != nil {
+					log.Errorf("Error renewing ACME certificate: %s", err.Error())
+				}
 			}
 		}
 	})

configuration.go

@@ -25,6 +25,7 @@ type TraefikConfiguration struct {
 type GlobalConfiguration struct {
 	GraceTimeOut              int64                   `short:"g" description:"Duration to give active requests a chance to finish during hot-reload"`
 	Debug                     bool                    `short:"d" description:"Enable debug mode"`
+	CheckNewVersion           bool                    `description:"Periodically check if a new version has been released"`
 	AccessLogsFile            string                  `description:"Access logs file"`
 	TraefikLogsFile           string                  `description:"Traefik logs file"`
 	LogLevel                  string                  `short:"l" description:"Log level"`
@@ -409,6 +410,7 @@ func NewTraefikConfiguration() *TraefikConfiguration {
 			DefaultEntryPoints:        []string{},
 			ProvidersThrottleDuration: time.Duration(2 * time.Second),
 			MaxIdleConnsPerHost:       200,
+			CheckNewVersion:           true,
 		},
 		ConfigFile: "",
 	}

docs/toml.md

@@ -9,6 +9,28 @@
 # Global configuration
 ################################################################
 
+# Timeout in seconds.
+# Duration to give active requests a chance to finish during hot-reloads
+#
+# Optional
+# Default: 10
+#
+# graceTimeOut = 10
+
+# Enable debug mode
+#
+# Optional
+# Default: false
+#
+# debug = true
+
+# Periodically check if a new version has been released
+#
+# Optional
+# Default: true
+#
+# checkNewVersion = false
+
 # Traefik logs file
 # If not defined, logs to stdout
 #

glide.yaml

@@ -107,4 +107,6 @@ import:
 - package: github.com/coreos/go-systemd
   version: v12
   subpackages:
-  - daemon
+  - daemon
+- package: github.com/google/go-github
+- package: github.com/hashicorp/go-version

traefik.go

@@ -11,6 +11,7 @@ import (
 	"runtime"
 	"strings"
 	"text/template"
+	"time"
 
 	"github.com/Sirupsen/logrus"
 	"github.com/containous/flaeg"
@@ -20,12 +21,12 @@ import (
 	"github.com/containous/traefik/log"
 	"github.com/containous/traefik/middlewares"
 	"github.com/containous/traefik/provider"
+	"github.com/containous/traefik/safe"
 	"github.com/containous/traefik/types"
 	"github.com/containous/traefik/version"
+	"github.com/coreos/go-systemd/daemon"
 	"github.com/docker/libkv/store"
 	"github.com/satori/go.uuid"
-
-	"github.com/coreos/go-systemd/daemon"
 )
 
 var versionTemplate = `Version:      {{.Version}}
@@ -263,6 +264,20 @@ func run(traefikConfiguration *TraefikConfiguration) {
 	}
 	jsonConf, _ := json.Marshal(globalConfiguration)
 	log.Infof("Traefik version %s built on %s", version.Version, version.BuildDate)
+
+	if globalConfiguration.CheckNewVersion {
+		ticker := time.NewTicker(24 * time.Hour)
+		safe.Go(func() {
+			version.CheckNewVersion()
+			for {
+				select {
+				case <-ticker.C:
+					version.CheckNewVersion()
+				}
+			}
+		})
+	}
+
 	if len(traefikConfiguration.ConfigFile) != 0 {
 		log.Infof("Using TOML configuration file %s", traefikConfiguration.ConfigFile)
 	}

traefik.sample.toml

@@ -10,6 +10,20 @@
 #
 # graceTimeOut = 10
 
+# Enable debug mode
+#
+# Optional
+# Default: false
+#
+# debug = true
+
+# Periodically check if a new version has been released
+#
+# Optional
+# Default: true
+#
+# checkNewVersion = false
+
 # Traefik logs file
 # If not defined, logs to stdout
 #

version/version.go

@@ -1,5 +1,12 @@
 package version
 
+import (
+	"github.com/containous/traefik/log"
+	"github.com/google/go-github/github"
+	goversion "github.com/hashicorp/go-version"
+	"net/url"
+)
+
 var (
 	// Version holds the current version of traefik.
 	Version = "dev"
@@ -8,3 +15,50 @@ var (
 	// BuildDate holds the build date of traefik.
 	BuildDate = "I don't remember exactly"
 )
+
+// CheckNewVersion checks if a new version is available
+func CheckNewVersion() {
+	if Version == "dev" {
+		return
+	}
+	client := github.NewClient(nil)
+	updateURL, err := url.Parse("https://update.traefik.io")
+	if err != nil {
+		log.Warnf("Error checking new version: %s", err)
+		return
+	}
+	client.BaseURL = updateURL
+	releases, resp, err := client.Repositories.ListReleases("containous", "traefik", nil)
+	if err != nil {
+		log.Warnf("Error checking new version: %s", err)
+		return
+	}
+
+	if resp.StatusCode != 200 {
+		log.Warnf("Error checking new version: status=%s", resp.Status)
+		return
+	}
+
+	currentVersion, err := goversion.NewVersion(Version)
+	if err != nil {
+		log.Warnf("Error checking new version: %s", err)
+		return
+	}
+
+	for _, release := range releases {
+		releaseVersion, err := goversion.NewVersion(*release.TagName)
+		if err != nil {
+			log.Warnf("Error checking new version: %s", err)
+			return
+		}
+
+		if len(currentVersion.Prerelease()) == 0 && len(releaseVersion.Prerelease()) > 0 {
+			continue
+		}
+
+		if releaseVersion.GreaterThan(currentVersion) {
+			log.Warnf("A new release has been found: %s. Please consider updating.", releaseVersion.String())
+			return
+		}
+	}
+}