Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal: UdpSockets.bind got 5 arguments, expected 4 #59

Closed
jsdario opened this issue Oct 25, 2017 · 2 comments
Closed

Fatal: UdpSockets.bind got 5 arguments, expected 4 #59

jsdario opened this issue Oct 25, 2017 · 2 comments

Comments

@jsdario
Copy link

jsdario commented Oct 25, 2017

  • Android (and iOS with different versions between native and JS)
  • react-native 0.47

How? Rerun npm install and apparently my code jumped to the latest version.

Maybe this commit 822b1e0 is passed through the native-js bridge with extra params, crashing on Android.

@mvayngrib
Copy link
Member

@jsdario oops, good catch, will release patch in a bit

@mvayngrib
Copy link
Member

mvayngrib commented Oct 25, 2017

fixed in 2.2.1

@jsdario it's a good thing for this library that 2.2.0 broke your code, but to prevent this kind of "automatic" update from breaking ur project in the future, set your semver in package.json to allow patches but not minor versions to sneak through:

package.json

"some-library": "~x.x.x"  <-- allows patch upgrades
"some-library": "^x.x.x"  <-- allows minor version upgrades (dangerous)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants