Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleValueData not supported any more in version 4.x.x? #66

Open
pnzr00t opened this issue Apr 16, 2024 · 2 comments
Open

SingleValueData not supported any more in version 4.x.x? #66

pnzr00t opened this issue Apr 16, 2024 · 2 comments

Comments

@pnzr00t
Copy link

pnzr00t commented Apr 16, 2024

Hello in my project i use SingleValueData in previous version all work correct, but currently it show me error

No exact matches in call to instance method 'setData'

        let data = [
            SingleValueData(time: .string("2019-05-28"), value: 46.01)
        ]
        series.setData(data: data)

May you give a hint at what of type i may replace SingleValueData?

PS

I make some research, and it's probably because you change here Sources/LightweightCharts/Implementations/API/Series/AreaSeries.swift in 4.0.0 version

From this code

public class AreaSeries: SeriesObject, SeriesApi {
    
    public typealias Options = AreaSeriesOptions
    public typealias TickValue = SingleValueData // <----- Here
    
}

to this

public class AreaSeries: SeriesObject, SeriesApi {
    
    public typealias Options = AreaSeriesOptions
    public typealias TickValue = AreaData // <----- Here
    
}
@pnzr00t
Copy link
Author

pnzr00t commented Apr 17, 2024

I create new SingleValueAreaSeries and other data structure for back compatibility, maybe it be useful

#68

@pnzr00t
Copy link
Author

pnzr00t commented Apr 19, 2024

As i understood, SingleValueData is not public data structure any more, but maybe we need delete them, or make it visibility as internal? As i see, now SingleValueData is useless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant