Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reduce mean ONNX op support #1637

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Add reduce mean ONNX op support #1637

merged 2 commits into from
Apr 16, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Apr 15, 2024

Related Issues/PRs

Progress towards #1544

Changes

Added reduce mean ONNX op import support

Testing

Added unit tests for codegen and expected outputs

@laggui laggui requested a review from antimora April 15, 2024 16:00
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 94.82759% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.34%. Comparing base (e303e31) to head (6805081).

Files Patch % Lines
crates/burn-import/src/onnx/op_configuration.rs 84.84% 5 Missing ⚠️
crates/burn-import/src/burn/node/unary.rs 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   86.30%   86.34%   +0.03%     
==========================================
  Files         691      691              
  Lines       79390    79503     +113     
==========================================
+ Hits        68520    68646     +126     
+ Misses      10870    10857      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding new ops.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laggui laggui merged commit d5f20e2 into main Apr 16, 2024
15 checks passed
@laggui laggui deleted the feat/onnx/reduce_mean branch April 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants