Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some execs that remain and do not exit #100

Open
xzchaoo opened this issue Mar 28, 2024 · 0 comments
Open

some execs that remain and do not exit #100

xzchaoo opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@xzchaoo
Copy link
Contributor

xzchaoo commented Mar 28, 2024

Describe this problem

image
For unknown reasons, there may be some execs that remain and do not exit.
I think we need to have some means to prevent arbitrary execs from hanging permanently.

Steps to reproduce

This problem is not easy to reproduce.
It is very likely that holoinsight-agent exited abnormally while tar was reading data from STDIN, causing STDIN to be unable to read EOF for a long time, so it hung.

Expected behavior

No exec remains.

Additional Information

There are several ideas:

  • Always use timeout to wrap all commands, and KILL when timeout occurs. But be aware that timeout can generate zombie processes in some scenarios. See #99
  • All exec commands carry special environment variable tags to indicate that they are calls from holoinsight-agent. Periodically clean up processes that need to be marked. See utils.go

No response

@xzchaoo xzchaoo added the bug Something isn't working label Mar 28, 2024
@xzchaoo xzchaoo self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant