From 9ef1a45e2d4569ebe6d3f6e2613e9e0d196eccc6 Mon Sep 17 00:00:00 2001
From: Thomas Prouvot <prouvot.t@gmail.com>
Date: Wed, 7 Jun 2023 13:57:39 +0200
Subject: [PATCH] Improve readability from object links by removing separators
 from a href

---
 addon/popup.js | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/addon/popup.js b/addon/popup.js
index f7b11541..a2e23bea 100644
--- a/addon/popup.js
+++ b/addon/popup.js
@@ -135,7 +135,7 @@ class App extends React.PureComponent {
     let linkTarget = inDevConsole || linkInNewTab ? "_blank" : "_top";
     return (
       h("div", {},
-        h("div", { className: "slds-grid slds-theme_shade slds-p-vertical_x-small slds-border_bottom"}, 
+        h("div", { className: "slds-grid slds-theme_shade slds-p-vertical_x-small slds-border_bottom" },
           h("div", { className: "header-logo" },
             h("div", { className: "header-icon slds-icon_container" },
               h("svg", { className: "slds-icon", viewBox: "0 0 24 24" },
@@ -165,13 +165,13 @@ class App extends React.PureComponent {
               h("a", { ref: "limitsBtn", href: "limits.html?" + hostArg, target: linkTarget, className: "page-button slds-button slds-button_neutral" }, h("span", {}, "Org ", h("u", {}, "L"), "imits"))
             ),
           ),
-          h("div", { className: "slds-p-vertical_x-small slds-p-horizontal_x-small" } ,
+          h("div", { className: "slds-p-vertical_x-small slds-p-horizontal_x-small" },
             // Advanded features should be put below this line, and the layout adjusted so they are below the fold
             h("div", { className: "slds-m-bottom_xx-small" },
               h("a", { ref: "metaRetrieveBtn", href: "metadata-retrieve.html?" + hostArg, target: linkTarget, className: "page-button slds-button slds-button_neutral" }, h("span", {}, h("u", {}, "D"), "ownload Metadata"))
             ),
             h("div", { className: "slds-m-bottom_xx-small" },
-              h("a", { ref: "apiExploreBtn", href: "explore-api.html?" + hostArg, target: linkTarget, className: "page-button slds-button slds-button_neutral" }, h("span", {}, "E", h("u", {}, "x"), "plore API") )
+              h("a", { ref: "apiExploreBtn", href: "explore-api.html?" + hostArg, target: linkTarget, className: "page-button slds-button slds-button_neutral" }, h("span", {}, "E", h("u", {}, "x"), "plore API"))
             ),
             h("div", { className: "slds-m-bottom_xx-small" },
               h("a",
@@ -192,7 +192,7 @@ class App extends React.PureComponent {
                   title: "You can choose if you want to open in a new tab or not",
                   target: linkTarget,
                   className: "page-button slds-button slds-button_neutral"
-                }, 
+                },
                 h("span", {}, "Salesforce ", h("u", {}, "H"), "ome"))
             ),
             inLightning && !isInSetup && h("div", { className: "slds-m-bottom_xx-small" },
@@ -203,7 +203,7 @@ class App extends React.PureComponent {
                   title: "You can choose if you want to open in a new tab or not",
                   target: linkTarget,
                   className: "page-button slds-button slds-button_neutral"
-                }, 
+                },
                 h("span", {}, "Setup ", h("u", {}, "H"), "ome")),
             ),
           )
@@ -222,7 +222,7 @@ class App extends React.PureComponent {
               value: apiVersionInput.split(".0")[0]
             })
           ),
-          h("div", { className: "slds-col slds-size_3-of-12 slds-text-align_left" }, 
+          h("div", { className: "slds-col slds-size_3-of-12 slds-text-align_left" },
             h("span", { className: "footer-small-text" }, navigator.userAgentData.platform.indexOf("mac") > -1 ? "[ctrl+option+i]" : "[ctrl+alt+i]" + " to open")
           ),
           h("div", { className: "slds-col slds-size_2-of-12 slds-text-align_right" },
@@ -1102,8 +1102,10 @@ class AllDataSelection extends React.PureComponent {
               h("tr", {},
                 h("th", {}, "Links:"),
                 h("td", {},
-                  h("a", { href: this.getObjectFieldsSetupLink(selectedValue.sobject.name, selectedValue.sobject.durableId, selectedValue.sobject.isCustomSetting), target: linkTarget }, "Fields / "),
-                  h("a", { href: this.getRecordTypesLink(sfHost, selectedValue.sobject.name, selectedValue.sobject.durableId), target: linkTarget }, "Record Types / "),
+                  h("a", { href: this.getObjectFieldsSetupLink(selectedValue.sobject.name, selectedValue.sobject.durableId, selectedValue.sobject.isCustomSetting), target: linkTarget }, "Fields"),
+                  h("span", {}, " / "),
+                  h("a", { href: this.getRecordTypesLink(sfHost, selectedValue.sobject.name, selectedValue.sobject.durableId), target: linkTarget }, "Record Types"),
+                  h("span", {}, " / "),
                   h("a", { href: this.getObjectListLink(selectedValue.sobject.name, selectedValue.sobject.keyPrefix, selectedValue.sobject.isCustomSetting), target: linkTarget }, "Object List")
                 ),
               ),