Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack in #363

Open
tpope opened this issue Aug 7, 2019 · 6 comments
Open

Jack in #363

tpope opened this issue Aug 7, 2019 · 6 comments

Comments

@tpope
Copy link
Owner

tpope commented Aug 7, 2019

Jobs make firing off lein repl :headless or a similar command in the background a much less dicey prospect than when Fireplace was introduced. Evaluate adding the option to start a REPL in the background.

@SevereOverfl0w
Copy link
Contributor

SevereOverfl0w commented Aug 7, 2019

https://github.com/clojure-vim/vim-jack-in might serve as inspiration

Feedback that I received on the initial vim-jack-in, people don't like it when closing their editor closes the REPL.

@benknoble
Copy link

I would be willing to try to work on this—is there any particularly good launching point? Or should I just look for where the commands are run and wrap them in an "if jobs, do that, otherwise do the original synchronous thing"?

@benknoble
Copy link

I need to reword that. Perhaps it would be simpler to simply write a ConnectBg or similar command that tries to launch the right repl in the background, and then runs FireplaceConnect as a callback.

@tpope
Copy link
Owner Author

tpope commented Oct 1, 2020

I think a separate command is probably the way to go. Calling FireplaceConnect in a callback might not be necessary if .nrepl-port or similar is created.

@benknoble
Copy link

Calling FireplaceConnect in a callback might not be necessary if .nrepl-port or similar is created.

Can I take this to mean that fireplace detects the creation of .nrepl-port and automatically connects? Or is it more like when a connection is needed, one is automatically created from .nrepl-port if it exists?

Another Q: does fireplace already have standard code for detecting lein vs. clojure-CLI (are there any others?), or would I need to write that/rip that from salve/classpath/etc.?

@tpope
Copy link
Owner Author

tpope commented Oct 1, 2020

Calling FireplaceConnect in a callback might not be necessary if .nrepl-port or similar is created.

Can I take this to mean that fireplace detects the creation of .nrepl-port and automatically connects? Or is it more like when a connection is needed, one is automatically created from .nrepl-port if it exists?

Automatically created on demand.

Another Q: does fireplace already have standard code for detecting lein vs. clojure-CLI (are there any others?), or would I need to write that/rip that from salve/classpath/etc.?

Nothing exists for this in Fireplace. In fact I am undecided on whether this feature should live inside of Fireplace or outside of it for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants