Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend API slightly: Allow/encourage dispatch on ADGradientWrapper and maybe expose an easy way to "remake"(?) an ADWrapper with a slightly modified wrapped LogDensityProblem. #20

Open
nsiccha opened this issue Aug 22, 2023 · 1 comment

Comments

@nsiccha
Copy link

nsiccha commented Aug 22, 2023

See above, sorry for the long title.

It would be nice to be able to dispatch on wrapped logdensity as e.g. here, but the source code says "[The abstract type ADGradientWrapper] is an implementation helper, not part of the API.", which sounds like one shouldn't dispatch on that type?

Also, it would be nice (i.e. convenient for me related to this issue), if based on some ADGradientWrapper, one could make another one just like it, but with the underlying logdensity replaced.

@tpapp
Copy link
Owner

tpapp commented Aug 22, 2023

I am wary of exposing type fields in the API, you can use parent and then dispatch on that (if you control the function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants