-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jpeg-recompress from danielgtaylor/jpeg-archive #65
Conversation
Looks interesting, thanks for contribution. |
def optimize(src, dst) | ||
quality_str = QUALITY_OPTIONS[quality] | ||
return false if quality_str == :lossless | ||
src.copy(dst) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why copy instead of using src
for input and dst
for output in arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No intentional reason, I think I just used jpeg_optim as a starter template, I can probably remove this.
Things I've notices:
Not sure about other arguments, with
|
…d optional lossy compression, resolves #65
…d optional lossy compression, resolves #65
@wjordan Once more thanks for contribution, merged and released v0.19.0 |
Thanks for finishing up and integrating the contribution! Glad it was helpful. I think the |
Adds support for the
jpeg-recompress
utility from danielgtaylor/jpeg-archive:I've set the program to be disabled by default. It is enabled by using the
--jpegoptim-max-quality N
option to set a JPEG quality preset other thanlossless
.Other configuration options are available aside from the quality preset, but I haven't added them to the
image_optim
options: