-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zopfli worker #18
Zopfli worker #18
Conversation
You need to use |
I see, zopflipng is not part of the 1.0.0 release, and seems to be in current master, but not in a version yet. Perhaps we should wait until Google releases a new version? We could try to ask the developers. |
Sure we can ask developer, but I think it is ok to use zopflipng even if there is no version with it. |
And there is no package zopfli, you need to compile it from source |
Imageoptim uses
I was just about to rebase and polish up the commits for the fixed version of this branch along with the necessary Travis-CI fixes and stuff before I do a pull request with a fixed version of this but then I decided to take a look at ImageOptim was doing. 😔 Then I looked at the default for the |
Wait, nevermind. I have no idea where I got that idea where ImageOptim was using |
How nice that advpng uses zopfli, that is pretty nice. I guess that makes this PR not needed, I was also tired of waiting on zopflipng. |
@nelsonjchen @kaspergrubbe I've already noticed that advpng uses zopfli, I was just thinking that image_optim should probably check version of advpng to warn if it is an outdated version without zopfli support, otherwise creating zopfli worker is redundant. |
This is initial idea of a Zopfli worker, but after working with it I am not sure it fits into the idea of image_optim.
Zopfli creates a .gz version of the png file, which seems to be incompatible with png openers (Which makes sense).
I took some ideas from https://github.com/mathiasbynens/grunt-zopfli/blob/master/tasks/zopfli.js
Do you have any idea how to approach this?
This references issue #17