Support for recursive extras #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
force-pushed
the
recursive-extra
branch
from
fa74f24
to
9c0d858
Compare
Signed-off-by: Bernát Gábor <[email protected]>
gaborbernat
force-pushed
the
recursive-extra
branch
from
9c0d858
to
90a7e4c
Compare
|
Dumb question: could this be adapted for pip-tools which also lack the support? It's like the final piece for standards-based workflows: jazzband/pip-tools#1685 |
|
That's a question for the pip-tools maintainers 👍 |
|
@hynek I keep an eye on pip-tools, I could help reviewing a PR. Still this in particular might be too tricky to implement and I would prefer to see lots of stuff removed from pip-tools before this would be added. So far, I prefered to avoid recursivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2568