From 186d76b3b2b8426d41edc69ef8f9eb71b14990cb Mon Sep 17 00:00:00 2001 From: GuyTempleton Date: Mon, 8 Mar 2021 22:38:30 +0000 Subject: [PATCH] Charts - Update Chart Lint and Test PR actions CA-Chart - Update Readmes and Image location --- .github/workflows/pr.yaml | 23 +++++++++++++--------- charts/README.md | 2 ++ charts/cluster-autoscaler/Chart.yaml | 4 ++-- charts/cluster-autoscaler/README.md | 15 +++++++++----- charts/cluster-autoscaler/README.md.gotmpl | 13 ++++++++---- charts/cluster-autoscaler/values.yaml | 2 +- 6 files changed, 38 insertions(+), 21 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index b7a8024e8f0f..3fca2de3323a 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -25,19 +25,24 @@ jobs: uses: actions/checkout@v2 - name: Fetch history run: git fetch --prune --unshallow - - id: lint - name: Run chart-testing (lint) + - name: Set up chart-testing uses: helm/chart-testing-action@v2.0.1 - with: - command: lint + - name: Run chart-testing (lint) + run: ct lint # Only build a kind cluster if there are chart changes to test. - - if: steps.lint.outputs.changed == 'true' + - name: Run chart-testing (list-changed) + id: list-changed + run: | + changed=$(ct list-changed) + if [[ -n "$changed" ]]; then + echo "::set-output name=changed::true" + fi + - if: steps.list-changed.outputs.changed == 'true' name: Create kind cluster uses: helm/kind-action@v1.1.0 - - name: Run chart-testing (install) - uses: helm/chart-testing-action@v2.0.1 - with: - command: install + - if: steps.list-changed.outputs.changed == 'true' + name: Run chart-testing (install) + run: ct install helm-docs-validate: if: ${{ needs.changes.outputs.charts == 'true' }} name: Helm Docs diff --git a/charts/README.md b/charts/README.md index 0f535a948795..5d4b78015342 100644 --- a/charts/README.md +++ b/charts/README.md @@ -17,6 +17,8 @@ The binary for `pre-commit` can be installed via Homebrew: $ brew install pre-commit ``` +For those without Homebrew, Pre-commit has [other installation methods available](https://pre-commit.com/#install). + ### Install git hooks After the `pre-commit` binary is installed, go to this repository's directory, and run the following command to install the git hook: diff --git a/charts/cluster-autoscaler/Chart.yaml b/charts/cluster-autoscaler/Chart.yaml index fd8d5e31dd40..5bf65e23fc47 100644 --- a/charts/cluster-autoscaler/Chart.yaml +++ b/charts/cluster-autoscaler/Chart.yaml @@ -3,7 +3,7 @@ appVersion: 1.20.0 description: Scales Kubernetes worker nodes within autoscaling groups. engine: gotpl home: https://github.com/kubernetes/autoscaler -icon: https://github.com/kubernetes/kubernetes/blob/master/logo/logo.png +icon: https://github.com/kubernetes/kubernetes/raw/master/logo/logo.png maintainers: - email: e.bailey@sportradar.com name: yurrriq @@ -17,4 +17,4 @@ name: cluster-autoscaler sources: - https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler type: application -version: 9.7.0 +version: 9.8.0 diff --git a/charts/cluster-autoscaler/README.md b/charts/cluster-autoscaler/README.md index e6588d3be85c..7a6582622819 100644 --- a/charts/cluster-autoscaler/README.md +++ b/charts/cluster-autoscaler/README.md @@ -35,16 +35,21 @@ This chart bootstraps a cluster-autoscaler deployment on a [Kubernetes](http://k The previous `cluster-autoscaler` Helm chart hosted at [helm/charts](https://github.com/helm/charts) has been moved to this repository in accordance with the [Deprecation timeline](https://github.com/helm/charts#deprecation-timeline). Note that a few things have changed between this version and the old version: - This repository **only** supports Helm chart installations using Helm 3+ since the `apiVersion` on the charts has been marked as `v2`. -- Previous versions of the Helm chart have not been migrated, and the version was reset to `1.0.0` initially. If you are looking for old versions of the chart, it's best to run `helm pull stable/cluster-autoscaler --version ` until you are ready to move to this repository's version. -- The previous versioning scheme has been returned to as of version `9.0.0` for ease of migration from the previous chart location. +- Previous versions of the Helm chart have not been migrated ## Migration from 1.X to 9.X+ versions of this Chart -On initial adoption of this chart this chart was renamed from `cluster-autoscaler` to `cluster-autoscaler-chart` due to technical limitations. This affects all `1.X` releases of the chart. +**TL;DR:** +You should choose to use versions >=9.0.0 of the `cluster-autoscaler` chart published from this repository; previous versions, and the `cluster-autoscaler-chart` with versioning 1.X.X published from this repository are deprecated. -Releases of the chart from `9.0.0` onwards return the naming of the chart to `cluster-autoscaler` and return to following the versioning established by the chart's previous location. +
+ Previous versions of this chart - further details +On initial migration of this chart from the `helm/charts` repository this chart was renamed from `cluster-autoscaler` to `cluster-autoscaler-chart` due to technical limitations. This affected all `1.X` releases of the chart, version 2.0.0 of this chart exists only to mark the [`cluster-autoscaler-chart` chart](https://artifacthub.io/packages/helm/cluster-autoscaler/cluster-autoscaler-chart) as deprecated. + +Releases of the chart from `9.0.0` onwards return the naming of the chart to `cluster-autoscaler` and return to following the versioning established by the chart's previous location at . To migrate from a 1.X release of the chart to a `9.0.0` or later release, you should first uninstall your `1.X` install of the `cluster-autoscaler-chart` chart, before performing the installation of the new `cluster-autoscaler` chart. +
## Migration from 9.0 to 9.1 @@ -361,7 +366,7 @@ Though enough for the majority of installations, the default PodSecurityPolicy _ | fullnameOverride | string | `""` | String to fully override `cluster-autoscaler.fullname` template. | | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.pullSecrets | list | `[]` | Image pull secrets | -| image.repository | string | `"us.gcr.io/k8s-artifacts-prod/autoscaling/cluster-autoscaler"` | Image repository | +| image.repository | string | `"k8s.gcr.io/autoscaling/cluster-autoscaler"` | Image repository | | image.tag | string | `"v1.20.0"` | Image tag | | kubeTargetVersionOverride | string | `""` | Allow overriding the `.Capabilities.KubeVersion.GitVersion` check. Useful for `helm template` commands. | | magnumCABundlePath | string | `"/etc/kubernetes/ca-bundle.crt"` | Path to the host's CA bundle, from `ca-file` in the cloud-config file. | diff --git a/charts/cluster-autoscaler/README.md.gotmpl b/charts/cluster-autoscaler/README.md.gotmpl index 3969d4545981..56d10bb2d3b6 100644 --- a/charts/cluster-autoscaler/README.md.gotmpl +++ b/charts/cluster-autoscaler/README.md.gotmpl @@ -35,16 +35,21 @@ This chart bootstraps a cluster-autoscaler deployment on a [Kubernetes](http://k The previous `cluster-autoscaler` Helm chart hosted at [helm/charts](https://github.com/helm/charts) has been moved to this repository in accordance with the [Deprecation timeline](https://github.com/helm/charts#deprecation-timeline). Note that a few things have changed between this version and the old version: - This repository **only** supports Helm chart installations using Helm 3+ since the `apiVersion` on the charts has been marked as `v2`. -- Previous versions of the Helm chart have not been migrated, and the version was reset to `1.0.0` initially. If you are looking for old versions of the chart, it's best to run `helm pull stable/cluster-autoscaler --version ` until you are ready to move to this repository's version. -- The previous versioning scheme has been returned to as of version `9.0.0` for ease of migration from the previous chart location. +- Previous versions of the Helm chart have not been migrated ## Migration from 1.X to 9.X+ versions of this Chart -On initial adoption of this chart this chart was renamed from `cluster-autoscaler` to `cluster-autoscaler-chart` due to technical limitations. This affects all `1.X` releases of the chart. +**TL;DR:** +You should choose to use versions >=9.0.0 of the `cluster-autoscaler` chart published from this repository; previous versions, and the `cluster-autoscaler-chart` with versioning 1.X.X published from this repository are deprecated. -Releases of the chart from `9.0.0` onwards return the naming of the chart to `cluster-autoscaler` and return to following the versioning established by the chart's previous location. +
+ Previous versions of this chart - further details +On initial migration of this chart from the `helm/charts` repository this chart was renamed from `cluster-autoscaler` to `cluster-autoscaler-chart` due to technical limitations. This affected all `1.X` releases of the chart, version 2.0.0 of this chart exists only to mark the [`cluster-autoscaler-chart` chart](https://artifacthub.io/packages/helm/cluster-autoscaler/cluster-autoscaler-chart) as deprecated. + +Releases of the chart from `9.0.0` onwards return the naming of the chart to `cluster-autoscaler` and return to following the versioning established by the chart's previous location at . To migrate from a 1.X release of the chart to a `9.0.0` or later release, you should first uninstall your `1.X` install of the `cluster-autoscaler-chart` chart, before performing the installation of the new `cluster-autoscaler` chart. +
## Migration from 9.0 to 9.1 diff --git a/charts/cluster-autoscaler/values.yaml b/charts/cluster-autoscaler/values.yaml index 005e2067d34b..0777e612dc5b 100644 --- a/charts/cluster-autoscaler/values.yaml +++ b/charts/cluster-autoscaler/values.yaml @@ -192,7 +192,7 @@ fullnameOverride: "" image: # image.repository -- Image repository - repository: us.gcr.io/k8s-artifacts-prod/autoscaling/cluster-autoscaler + repository: k8s.gcr.io/autoscaling/cluster-autoscaler # image.tag -- Image tag tag: v1.20.0 # image.pullPolicy -- Image pull policy