-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@FlowInterop.Disabled does not work in the constructor #97
Comments
Hi @X1nto, thanks for the report. The header always shows
Let me know if that changes anything. |
Hi! The annotation doesn't work because it targets the property, not the value parameter. Skie currently doesn't support Flow configuration for individual value parameters - it's a limitation of our current configuration framework. As for why the annotation does not support constructors: I don't think it's intentional. We likely forgot to include the constructor target in there, so this is a "bug". |
Do you accept PRs? I'll try and see if I can fix it |
Theoretically, yes, but we need to add tests as well, and those are not public, so a PR wouldn't save us any work in this case, unfortunately. |
Questions:
What is the problem?
Applying
@FlowInterop.Disabled
to a constructor property still generates initializers with SkieSwiftFlow.When does the problem occur?
During Swift compilation(?)
The initializer in the generated header does use
Kotlinx_coroutines_coreFlow
, but Xcode fails to see coreFlow and still treats it as SkieFlowHow do we reproduce the issue?
Add this class to the iosMain source set of the shared module:
Try using the class from Swift:
What has changed since the last time SKIE worked in your project?
If only I knew.
What versions of SKIE, Kotlin, and Gradle do you use?
Skie 0.8.3
Kotlin 2.0.0
Gradle 8.9
Xcode 15.4
What is your SKIE Gradle configuration?
Default configuration, no
skie {}
block.There must be something that I'm missing. I've been going crazy these past 7 hours trying to fix this problem. The generated header being correct is what makes me actually mad, since it's probably some obscure Xcode bug that no one has ever encountered.
The text was updated successfully, but these errors were encountered: