Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS: Wrong digits count with underscores #1

Open
maccasoft opened this issue Apr 20, 2016 · 0 comments
Open

AS: Wrong digits count with underscores #1

maccasoft opened this issue Apr 20, 2016 · 0 comments

Comments

@maccasoft
Copy link

When a constant number is defined with the underscores, the number is built correctly but the underscores are counted as valid digits, which is wrong. There aren't problems when the total number of characters is below the maximum expected, but when it is exceeded it has a weird effect: with linux it works and the number is evaluated correctly, with windows it throws an error 'junk at end of line'.

For example:

test     long    $123_4567   ' Works on both
test2    long    $1234_5678  ' Linux works, windows fails

I tought it was an issue with the windows build, but it is an issue with the linux build that doesn't report the error.

The attached patch adjusts the count of too_many_digits to include the underscores while they are skipped. I wasn't able to find why the linux build doesn't throw the error, hope it doesn't cause other issues.

too_many_digits_fix.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant