Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint v6 #16

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Support ESLint v6 #16

merged 2 commits into from
Aug 29, 2019

Conversation

efoken
Copy link
Contributor

@efoken efoken commented Aug 28, 2019

No description provided.

efoken added 2 commits August 28, 2019 14:12
To archive this, we have to remove `eslint` from dependencies, or at
least move it to devDependencies. Then both versions, v5 and v6 are
added as peerDependencies, so that users can decide.
@efoken efoken mentioned this pull request Aug 28, 2019
@toshi-toma toshi-toma self-requested a review August 29, 2019 13:53
Copy link
Owner

@toshi-toma toshi-toma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
thank you for your contribution 👍

@toshi-toma toshi-toma merged commit e52153f into toshi-toma:master Aug 29, 2019
toshi-toma pushed a commit that referenced this pull request Aug 29, 2019
* feat: support ESLint v6 as well as ESLint v5

To archive this, we have to remove `eslint` from dependencies, or at
least move it to devDependencies. Then both versions, v5 and v6 are
added as peerDependencies, so that users can decide.

* fix: fix error in tsconfig caused by new typescript-eslint

See
<typescript-eslint/typescript-eslint#853 (comment)>
for details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants