Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail editing UI looks broken #45

Open
thibaudcolas opened this issue May 8, 2019 · 1 comment
Open

Thumbnail editing UI looks broken #45

thibaudcolas opened this issue May 8, 2019 · 1 comment
Labels
Milestone

Comments

@thibaudcolas
Copy link
Member

In the audio/video edit views, the thumbnail editing UI doesn't look right:

thumbnail-edit

  • "Change thumbnail file: Currently:" provides the same info as the thumbnail's file name + link above it
  • "Clear" and its checkbox aren't side by side
  • "Change" isn't styled like "Clear" is

Tested with Wagtail 2.3.

This seems like it might have been caused by changes in Wagtail's styles that this extension might be relying on, but I didn't investigate further.

@thenewguy
Copy link
Collaborator

This is because the template duplicates the widget output.

Should probably leave this to the widget and remove the anchor rendered by the template.

Could probably update the file widget to be the same here and simplify in one issue

@zerolab zerolab added this to the 0.12 milestone Oct 15, 2022
@zerolab zerolab modified the milestones: 0.12, The big tidy up Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants