This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
feat(repository): make abc more general. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ABC was typed to accept a sqlalchemy session object. Changed to instead receive arbitrary kwargs, but if the base class actually ever receives kwargs it will error out due to super call to `object.__init__()`. The service object accepts arbitrary kwargs that are passed through to the repository, but doesn't care what they are. This all means that the only thing that knows and cares about the sqlalchemy session, is the sqlalchemy repository, and that feels right. One facet of this approach is that it makes the concept of the transaction an implementation detail. The sqlalchemy repo has the concept of session/transaction, but a repository doesn't _have_ to understand those things. This is consistent with the testing repository implementation, so happy to see how the pattern pans out. Closes #54
peterschutt
added a commit
that referenced
this pull request
Nov 5, 2022
The ABC was typed to accept a sqlalchemy session object. Changed to instead receive arbitrary kwargs, but if the base class actually ever receives kwargs it will error out due to super call to `object.__init__()`. The service object accepts arbitrary kwargs that are passed through to the repository, but doesn't care what they are. This all means that the only thing that knows and cares about the sqlalchemy session, is the sqlalchemy repository, and that feels right. One facet of this approach is that it makes the concept of the transaction an implementation detail. The sqlalchemy repo has the concept of session/transaction, but a repository doesn't _have_ to understand those things. This is consistent with the testing repository implementation, so happy to see how the pattern pans out. Closes #54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABC was typed to accept a sqlalchemy session object. Changed to instead receive arbitrary kwargs, but if the base class actually ever receives kwargs it will error out due to super call to
object.__init__().The service object accepts arbitrary kwargs that are passed through to the repository, but doesn't care what they are.
This all means that the only thing that knows and cares about the sqlalchemy session, is the sqlalchemy repository, and that feels right.
One facet of this approach is that it makes the concept of the transaction an implementation detail. The sqlalchemy repo has the concept of session/transaction, but a repository doesn't have to understand those things. This is consistent with the testing repository implementation, so happy to see how the pattern pans out.
Closes #54