Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

question: use msgpack for Redis serialization? #269

Open
cofin opened this issue Jan 22, 2023 · 1 comment
Open

question: use msgpack for Redis serialization? #269

cofin opened this issue Jan 22, 2023 · 1 comment
Labels
question Further information is requested

Comments

@cofin
Copy link
Collaborator

cofin commented Jan 22, 2023

I've been wondering if it would be worthwhile to use the msgpack support built into msgspec instead of JSON, and I thought I'd bring up the topic to a larger group.

I've created a working branch (saq-reconnect) here

Take a look and let me know if you think it's something that makes sense to evaluate further.

@cofin cofin added the question Further information is requested label Jan 22, 2023
@peterschutt
Copy link
Member

Seems good to me.. if for whatever reason a downstream app really wanted to use json they can subclass the queue and configure it themselves.

Ser/de for the queue really should just be an implementation detail, and if msgspec would indeed be smaller and faster then it makes perfect sense to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants