Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

feat: optional audit columns on base class #264

Merged
merged 4 commits into from
Jan 20, 2023
Merged

feat: optional audit columns on base class #264

merged 4 commits into from
Jan 20, 2023

Conversation

peterschutt
Copy link
Member

No description provided.

@peterschutt peterschutt requested a review from cofin January 19, 2023 04:18
Copy link
Collaborator

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! Thanks for making those changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@peterschutt peterschutt merged commit 0b0085d into 0.29 Jan 20, 2023
@peterschutt peterschutt deleted the orm-mixins-ps branch January 20, 2023 05:23
@peterschutt
Copy link
Member Author

This is perfect! Thanks for making those changes.

No probs, thanks for the suggestion!

peterschutt added a commit that referenced this pull request Jan 20, 2023
* feat: makes the `created/updated` indicators on ORM models optional.

* fix: remove unused ignore.

* feat: choice of declarative base with/without audit columns.

* test: coverage! coverage! coverage!

Co-authored-by: Cody Fincher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants