This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
fix(sentry): configure sentry before app instantiation #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Good catch! I've slightly refactored I'll create a 0.29 release branch and we can work into that. |
peterschutt
force-pushed
the
fix/sentry-integration
branch
from
4c3f848 to
6818410
Compare
|
Thanks again @gazorby ! |
peterschutt
added a commit
that referenced
this pull request
Jan 20, 2023
* 🐛 fix(sentry): call configure before starlite init * chore: changes for rebase on 0.29 Co-authored-by: Peter Schutt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib call
sentry.configureas part of starlite'son_app_inithook, but as sentry integration patchStarlite.__init__(and other stuff too), it does not take effect for the app being instantiated. So we must configure sentry early, beforeon_app_initto ensure sentry's monkeypatching will be used.