This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
fix(server)!: fix reloading config #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic for reloading is in `uvicorn.run()`, but to use it we need to let uvicorn manage the event loop for us. So this commit moves the database/cache readiness checks into a starlite, "before_startup" hook handler, so that they are conducted after uvicorn has setup the event loop.
This was referenced Jan 12, 2023
Merged
peterschutt
added a commit
that referenced
this pull request
Jan 12, 2023
* ✨ feat(scripts): auto reload when ENVIRONMENT==local * 🐛 fix: typing and docs * fix(reloading): use `uvicorn.run()` Logic for reloading is in `uvicorn.run()`, but to use it we need to let uvicorn manage the event loop for us. So this commit moves the database/cache readiness checks into a starlite, "before_startup" hook handler, so that they are conducted after uvicorn has setup the event loop. Co-authored-by: gazorby <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr moves the database/cache readiness checks into the starlite before_startup hook, which removes our need to use the event loop before we startup the application.
This means we can let starlette manage the event loop for us, taking away the need to do a lot of dancing around the fact that starlette assume they should be managing the event loop.
Adds automatic entry into reloading mode if environment is set to "local".