Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

bug: #219 doesn't allow for skipping cache/db readiness checks #230

Closed
peterschutt opened this issue Jan 12, 2023 · 2 comments
Closed

bug: #219 doesn't allow for skipping cache/db readiness checks #230

peterschutt opened this issue Jan 12, 2023 · 2 comments

Comments

@peterschutt
Copy link
Member

#219 introduced a change to the run-app script where the database/cache readiness checks were moved into the before start lifespan hook in starlite.

This means that the args --no-db etc are no longer a part of the startup script, and therefore we no longer have a way to skip them.

Maybe we can just add configs to the plugin config object that allow them to be explicitly skipped.

@gazorby
Copy link
Collaborator

gazorby commented Jan 13, 2023

Isn't this solved by 76b5928?

@peterschutt
Copy link
Member Author

Yep, I should have closed this off!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants