Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: adding compaction on DB open #456

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Freyskeyd
Copy link
Member

Description

Adds a manual compaction when opening the DB on pending_pool and precedence_pool CF

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd requested a review from a team as a code owner February 15, 2024 09:38
@Freyskeyd Freyskeyd changed the base branch from main to release/v0.0.11 February 15, 2024 09:38
@Freyskeyd Freyskeyd changed the title chore: increase payload size for sync in config (#451) chore: adding compaction on open Feb 15, 2024
@Freyskeyd Freyskeyd changed the title chore: adding compaction on open chore: adding compaction on DB open Feb 15, 2024
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok doing this, but there's a risk here: on a big rocksdb, doing compaction can take a long time and afaik there is no way to know just how long it takes.

We can mitigate this risk by making it optional by way of a config option, or have a subcommand that does the compaction while the node is running (this is safe because rocksdb runs compactions on its own whenever it wants to).

@Freyskeyd Freyskeyd merged commit 3407732 into release/v0.0.11 Feb 15, 2024
9 checks passed
@Freyskeyd Freyskeyd deleted the chore/expose-metrics-storage-pool-2 branch February 15, 2024 14:39
Freyskeyd added a commit that referenced this pull request Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants