Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: add next_pending_certificate on end task #455

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Feb 14, 2024

Description

This PR adds a call to get_next_pending_certificates after a task ends in order to process next pending certificates.
It also removes some old struct/mechanism of the broadcast.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner February 14, 2024 15:32
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (90405f3) 68.07% compared to head (5378b38) 68.24%.

Files Patch % Lines
crates/topos-tce-broadcast/src/task_manager/mod.rs 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   68.07%   68.24%   +0.16%     
==========================================
  Files         223      223              
  Lines       12331    12258      -73     
==========================================
- Hits         8394     8365      -29     
+ Misses       3937     3893      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove .unwrap()

@dvdplm dvdplm dismissed gruberb’s stale review February 16, 2024 10:48

I agree with Simon here: panics are ok in benchmarks and tests.

@dvdplm dvdplm merged commit 2aaa500 into main Feb 16, 2024
23 checks passed
@dvdplm dvdplm deleted the fix/delivery-time-task-manager branch February 16, 2024 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants