This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat: track queue size in metrics/graphql #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
requested review from
dvdplm and
hadjiszs
and removed request for
a team
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
chore/expose-metrics-storage-pool
branch
from
2e02bd7
to
5ef7657
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.0.11 #454 +/- ##
==================================================
Coverage ? 69.49%
==================================================
Files ? 220
Lines ? 12394
Branches ? 0
==================================================
Hits ? 8613
Misses ? 3781
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dvdplm
approved these changes
Feb 14, 2024
|
|
||
| #[derive(Debug, Deserialize)] | ||
| struct Response { | ||
| // data: HashMap<String, serde_json::Value>, |
| @@ -232,8 +233,11 @@ impl WriteStore for FullNodeStore { | |||
| } | |||
|
|
|||
| impl ReadStore for FullNodeStore { | |||
| fn count_certificates_delivered(&self) -> Result<usize, StorageError> { | |||
| Ok(self.perpetual_tables.certificates.iter()?.count()) | |||
| fn count_certificates_delivered(&self) -> Result<u64, StorageError> { | |||
There was a problem hiding this comment.
Maybe we should call this estimate_certs_delivered?
| @@ -33,6 +33,9 @@ pub enum InternalStorageError { | |||
| #[error("Invalid query argument: {0}")] | |||
| InvalidQueryArgument(&'static str), | |||
|
|
|||
| #[error("Unexpected DB state: {0}")] | |||
| UnexpectedDBState(&'static str), | |||
There was a problem hiding this comment.
It's not really a problem with the DB state if a property is missing. Wouldn't this error be for a situation where there's a new/old/incompatible rocksdb version that does not support some property?
hadjiszs
approved these changes
Feb 14, 2024
Freyskeyd
added a commit
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Simon Paitrault <[email protected]> Co-authored-by: David Palm <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new metrics accessible on the default port
3000(e.g.:localhost:3000):STORAGE_PENDING_POOL_COUNTthat tracks the number of certificates in thepending_pool.STORAGE_PRECEDENCE_POOL_COUNTthat tracks the number of certificates in theprecedence_pool.rocksdbmetadata:The
GraphQLAPI is exposing those value undergetStoragePoolStats.PR Checklist: