This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
requested review from
dvdplm and
atanmarko
and removed request for
a team
February 6, 2024 18:43
gruberb
suggested changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to comment the current_bootstrap_id
. Question also: Why current_*
? And the type is QueryId
. Should we rename it then to query_id
?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
+ Coverage 68.07% 70.72% +2.65%
==========================================
Files 223 222 -1
Lines 12331 12300 -31
==========================================
+ Hits 8394 8699 +305
+ Misses 3937 3601 -336 ☔ View full report in Codecov by Sentry. |
dvdplm
reviewed
Feb 8, 2024
Freyskeyd
force-pushed
the
chore/move-telemetry-otlp
branch
from
February 8, 2024 18:54
ab72e67
to
cda0d02
Compare
Freyskeyd
force-pushed
the
feature/tp-818
branch
from
February 8, 2024 19:21
bc04bc7
to
c995470
Compare
dvdplm
reviewed
Feb 9, 2024
Freyskeyd
force-pushed
the
feature/tp-818
branch
17 times, most recently
from
February 12, 2024 11:28
f682bb1
to
5acc673
Compare
Freyskeyd
force-pushed
the
feature/tp-818
branch
3 times, most recently
from
February 12, 2024 13:48
62f0252
to
6ad0090
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
feature/tp-818
branch
from
February 12, 2024 13:51
6ad0090
to
241307b
Compare
Signed-off-by: Simon Paitrault <[email protected]>
Freyskeyd
force-pushed
the
feature/tp-818
branch
from
February 12, 2024 14:09
241307b
to
521587e
Compare
gruberb
reviewed
Feb 12, 2024
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
gruberb
approved these changes
Feb 12, 2024
dvdplm
approved these changes
Feb 13, 2024
Signed-off-by: Simon Paitrault <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the DHT publication of the addresses of the node on the Kademlia DHT.
It is not needed anymore as we rely on
gossipsub
for the broadcast and ongRPC over p2p
for anything else.PR Checklist: