Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: remove dht publication #449

Merged
merged 8 commits into from
Feb 15, 2024
Merged

feat: remove dht publication #449

merged 8 commits into from
Feb 15, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR removes the DHT publication of the addresses of the node on the Kademlia DHT.
It is not needed anymore as we rely on gossipsub for the broadcast and on gRPC over p2p for anything else.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd marked this pull request as ready for review February 6, 2024 18:43
@Freyskeyd Freyskeyd requested a review from a team as a code owner February 6, 2024 18:43
@Freyskeyd Freyskeyd requested review from dvdplm and atanmarko and removed request for a team February 6, 2024 18:43
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to comment the current_bootstrap_id. Question also: Why current_*? And the type is QueryId. Should we rename it then to query_id?

crates/topos-p2p/src/runtime/mod.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (90405f3) 68.07% compared to head (5b41691) 70.72%.

Files Patch % Lines
crates/topos-p2p/src/runtime/mod.rs 69.23% 4 Missing ⚠️
crates/topos-p2p/src/behaviour/discovery.rs 99.19% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   68.07%   70.72%   +2.65%     
==========================================
  Files         223      222       -1     
  Lines       12331    12300      -31     
==========================================
+ Hits         8394     8699     +305     
+ Misses       3937     3601     -336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.cargo/nextest.toml Outdated Show resolved Hide resolved
crates/topos-p2p/src/runtime/mod.rs Outdated Show resolved Hide resolved
docs/architecture/addr_announcer.md Show resolved Hide resolved
crates/topos-p2p/src/runtime/mod.rs Show resolved Hide resolved
Base automatically changed from chore/move-telemetry-otlp to main February 8, 2024 19:17
@Freyskeyd Freyskeyd marked this pull request as draft February 9, 2024 10:21
@Freyskeyd Freyskeyd force-pushed the feature/tp-818 branch 17 times, most recently from f682bb1 to 5acc673 Compare February 12, 2024 11:28
@Freyskeyd Freyskeyd force-pushed the feature/tp-818 branch 3 times, most recently from 62f0252 to 6ad0090 Compare February 12, 2024 13:48
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd marked this pull request as ready for review February 12, 2024 14:10
crates/topos-p2p/src/behaviour/discovery.rs Outdated Show resolved Hide resolved
crates/topos-p2p/src/behaviour/discovery.rs Outdated Show resolved Hide resolved
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd merged commit 7030341 into main Feb 15, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the feature/tp-818 branch February 15, 2024 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants