Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: add benchmark dns option to spam subcommand #448

Merged
merged 13 commits into from
Feb 9, 2024
Merged

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Feb 6, 2024

Description

When operating topos nodes in a Kubernetes environment, we have to address each service through a Kubernetes abstraction, called a pod. These pods are networked via DNS. When testing the network via topos regtest spam our fixed IP_ADDRESS:PORT approach of talking to each node doesn't work. We therefore add new flags to the command:

topos regtest spam --benchmark --dns "http://validator-{N}:1340" --number 10

Fixes TP-852

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@gruberb gruberb requested a review from a team as a code owner February 6, 2024 13:45
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (23cc558) 67.34% compared to head (4b7a277) 69.62%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/topos-certificate-spammer/src/lib.rs 55.00% 9 Missing ⚠️
crates/topos-telemetry/src/tracing.rs 40.00% 3 Missing ⚠️
crates/topos-telemetry/src/lib.rs 0.00% 2 Missing ⚠️
crates/topos-certificate-spammer/src/config.rs 0.00% 1 Missing ⚠️
...ates/topos/src/components/regtest/commands/spam.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   67.34%   69.62%   +2.27%     
==========================================
  Files         223      223              
  Lines       12271    12331      +60     
==========================================
+ Hits         8264     8585     +321     
+ Misses       4007     3746     -261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruberb gruberb changed the title feat: add kubernetes dns option to spam subcommand feat: add benchmark dns option to spam subcommand Feb 7, 2024
@gruberb gruberb force-pushed the feat/TP-852 branch 2 times, most recently from 937412c to 1985228 Compare February 8, 2024 19:07
Copy link
Member

@Freyskeyd Freyskeyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little comments but not blocking

crates/topos-certificate-spammer/src/lib.rs Outdated Show resolved Hide resolved
@gruberb gruberb merged commit 90405f3 into main Feb 9, 2024
21 checks passed
@gruberb gruberb deleted the feat/TP-852 branch February 9, 2024 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants