This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add benchmark dns option to spam subcommand #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 67.34% 69.62% +2.27%
==========================================
Files 223 223
Lines 12271 12331 +60
==========================================
+ Hits 8264 8585 +321
+ Misses 4007 3746 -261 ☔ View full report in Codecov by Sentry. |
Freyskeyd
reviewed
Feb 6, 2024
dvdplm
reviewed
Feb 7, 2024
crates/topos/tests/snapshots/regtest__regtest_spam_help_display.snap
Outdated
Show resolved
Hide resolved
gruberb
changed the title
feat: add kubernetes dns option to spam subcommand
feat: add benchmark dns option to spam subcommand
Feb 7, 2024
dvdplm
reviewed
Feb 8, 2024
crates/topos/tests/snapshots/regtest__regtest_spam_help_display.snap
Outdated
Show resolved
Hide resolved
Freyskeyd
reviewed
Feb 8, 2024
gruberb
force-pushed
the
feat/TP-852
branch
2 times, most recently
from
February 8, 2024 19:07
937412c
to
1985228
Compare
Signed-off-by: Bastian Gruber <[email protected]>
Freyskeyd
reviewed
Feb 9, 2024
Freyskeyd
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little comments but not blocking
atanmarko
reviewed
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When operating
topos
nodes in a Kubernetes environment, we have to address each service through a Kubernetes abstraction, called apod
. These pods are networked viaDNS
. When testing the network viatopos regtest spam
our fixedIP_ADDRESS:PORT
approach of talking to each node doesn't work. We therefore add new flags to the command:Fixes TP-852
PR Checklist: