Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

refactor: tce-broadcast config #444

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

Freyskeyd
Copy link
Member

Description

This PR aims to refactor some part of the TCE broadcast configuration.
It also remove some unused code such as StableSample event.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd changed the base branch from main to feature/tp-844 January 29, 2024 14:11
@Freyskeyd Freyskeyd changed the title refac: tce-broadcast config refactor: tce-broadcast config Jan 29, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ff2a23) 68.75% compared to head (c12f785) 69.21%.
Report is 1 commits behind head on main.

Files Patch % Lines
...es/topos-p2p/src/runtime/handle_event/discovery.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   68.75%   69.21%   +0.45%     
==========================================
  Files         220      222       +2     
  Lines       12141    12135       -6     
==========================================
+ Hits         8348     8399      +51     
+ Misses       3793     3736      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd marked this pull request as ready for review January 30, 2024 07:28
@Freyskeyd Freyskeyd requested a review from a team as a code owner January 30, 2024 07:28
@Freyskeyd Freyskeyd requested review from hadjiszs and JDawg287 and removed request for a team January 30, 2024 07:28
@Freyskeyd Freyskeyd force-pushed the refactor/tce-broadcast-config branch from a08d586 to 8d9cf56 Compare January 30, 2024 08:10
@Freyskeyd Freyskeyd force-pushed the refactor/tce-broadcast-config branch from 8d9cf56 to dae06fe Compare January 30, 2024 10:59
Base automatically changed from feature/tp-844 to main January 31, 2024 13:30
@Freyskeyd Freyskeyd force-pushed the refactor/tce-broadcast-config branch from dae06fe to e73dec5 Compare January 31, 2024 13:31
crates/topos-config/src/tce/broadcast.rs Outdated Show resolved Hide resolved
crates/topos-tce-broadcast/src/event.rs Show resolved Hide resolved
crates/topos-config/src/tce.rs Show resolved Hide resolved
crates/topos-config/src/tce/broadcast.rs Show resolved Hide resolved
crates/topos-config/src/tce/broadcast.rs Show resolved Hide resolved
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the refactor/tce-broadcast-config branch from 90258b3 to c12f785 Compare February 7, 2024 21:02
@Freyskeyd Freyskeyd merged commit 10c3879 into main Feb 8, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the refactor/tce-broadcast-config branch February 8, 2024 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants