Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: refactor struct in topos-core #437

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Jan 22, 2024

Description

Update some structs after the merge of topos-core, topos-uci and topos-api.

Breaking changes

BREAKING CHANGE: This break the 0.0.10 GraphQL API definition due to the rename of some fields.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd changed the base branch from main to feature/tp-761/reorganization January 22, 2024 19:41
@Freyskeyd Freyskeyd changed the base branch from feature/tp-761/reorganization to chore/tp-776 January 22, 2024 19:42
@Freyskeyd Freyskeyd force-pushed the chore/tp-776 branch 2 times, most recently from b7156cc to e3b3c10 Compare January 23, 2024 10:07
Base automatically changed from chore/tp-776 to main January 23, 2024 10:21
@Freyskeyd Freyskeyd marked this pull request as ready for review January 23, 2024 10:49
@Freyskeyd Freyskeyd requested a review from a team as a code owner January 23, 2024 10:49
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (355b08a) 0.00% compared to head (61f22de) 68.37%.

Files Patch % Lines
crates/topos-core/src/api/graphql/certificate.rs 66.66% 2 Missing ⚠️
crates/topos-tce-api/src/graphql/query.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #437       +/-   ##
=========================================
+ Coverage      0   68.37%   +68.37%     
=========================================
  Files         0      224      +224     
  Lines         0    13106    +13106     
=========================================
+ Hits          0     8961     +8961     
- Misses        0     4145     +4145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd merged commit acedac7 into main Jan 24, 2024
30 of 37 checks passed
@Freyskeyd Freyskeyd deleted the chore/refactor-struct-core branch January 24, 2024 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants